Review Board 1.7.16


Bridge core: Pass a ref with the swap channel when joining a bridge.

Review Request #4354 - Created Jan. 19, 2015 and submitted

rmudgett
13
ASTERISK-24649
Reviewers
asterisk-dev
Asterisk
When code imparts a channel into a bridge to swap with another channel, a ref needs to be held on the swap channel to ensure that it cannot dissapear before finding it in the bridge.

* The ast_bridge_join() swap channel parameter now always steals a ref for the swap channel.  This is the only change to the bridge framework's public API semantics.

* bridge_channel_internal_join() now requires the bridge_channel->swap channel to pass in a ref.
The testsutite masquerade super test and the --tags=transfer tests still pass.
Total:
4
Open:
0
Resolved:
0
Dropped:
4
Status:
From:
Review request changed
Updated (Jan. 22, 2015, 2:23 p.m.)
  • changed from pending to submitted
Committed in revision 430992

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.