Review Board 1.7.16


res_pjsip: make it unloadable (take 2)

Review Request #4363 - Created Jan. 21, 2015 and submitted

Kevin Harwell
13
ASTERISK-24485
Reviewers
asterisk-dev
Asterisk
The res_pjsip module was previously unloadable. With this patch it can now be unloaded.

This patch is based off the original patch on the issue by Corey Farrell with a few modifications. Removed a few changes not required to make the module unloadable and also fixed a bug that would cause asterisk to crash on unloading.

The first patch (found here: https://reviewboard.asterisk.org/r/4311/) had to be reverted due to a race condition it introduced on shutdown. It turned out that the following change to stasis_message_router was the cause (~line 258):

router->subscription = stasis_unsubscribe(router->subscription);

The patch found here is the original patch plus the fix for the problem (added locking).
Ran the relevant unit and testsuite tests on two different machines since original patch passed on one.  Also verified that the module could unload and shutdown properly without any extra dependencies.
Review request changed
Updated (Jan. 27, 2015, 1:23 p.m.)
  • changed from pending to submitted
Committed in revision 431199

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.