Review Board 1.7.16


Update res_format_attr_opus & res_format_attr_silk to new media formats architecture

Review Request #4371 - Created Jan. 26, 2015 and submitted

Sean Bright
13
Reviewers
asterisk-dev
Asterisk
In r419044, we changed how formats were handled, but the return value of the format_parse_sdp_fmtp functions in res_format_attr_opus and res_format_attr_silk were not updated, causing calls to fail.  Ran into this when getting codec_opus working with Asterisk 13.

Once the return value was corrected, we were crashing in opus_getjoint because of NULL format attributes.  I've fixed this as well in this patch.  There may be a similar issue with SILK, but I don't have access to codec_silk for Asterisk 13 so I cannot test.
Ran a test call with codec_opus.
Review request changed
Updated (Jan. 28, 2015, 8:36 a.m.)
  • changed from pending to submitted
Committed in revision 431268

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.