Review Board 1.7.16


res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

Review Request #4412 - Created Feb. 10, 2015 and submitted

Kevin Harwell
13
ASTERISK-24701
Reviewers
asterisk-dev
Asterisk
When writing to a websocket if a timeout occurred the underlying socket did not get closed/disconnected. This patch makes sure the websocket gets disconnected on a write timeout. Also a notice is logged stating that the websocket was disconnected.
I had trouble getting an actual write timeout to occur, so I just forced an error on write to make sure the underlying socket would get closed and the notice was logged. Also ran relevant testsuite and unit tests.
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (Feb. 11, 2015, 12:24 p.m.)
  • changed from pending to submitted
Committed in revision 431715

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.