Review Board 1.7.16


SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 11

Review Request #4419 - Created Feb. 13, 2015 and submitted

Matt Jordan
11
ASTERISK-17721, ASTERISK-17899, ASTERISK-22748
4418
Reviewers
asterisk-dev
oej
Asterisk
Note that this patch is a forward port of oej's lingon-srtp-key-lifetime-1.8 branch, with a few small modifications to reduce block indentation and a few improvements made to surrounding existing code.

To quote Olle from ASTERISK-17721:

{quote}
The Lingon branch now handle lifetime and MKI parameters.

We only accept lifetimes up to max for the crypto and higher than 10 hours for packetization of 20 ms (50 pps).

We only handle MKI with index 1.

We do not really bother with counting packets and reinviting at end of lifetime, so the min of 10 hours kind of takes care of most calls. If there are longer ones, we rely on the other side for re-invites.

It's still not perfect, but I personally think this is an improvement. A configuration option for minimum lifetime accepted could be added.
{quote}

I personally don't think the minimum lifetime option is needed, as in practice, every instance of an SDP offer for SDES-SRTP with lifetime I've seen offers a lifetime of 2^32 - but it could be added in the future if necessary.

Note that since the sdp_crypto code was moved to the core in 12+, a separate review (r4418) has been made for the Asterisk 13 variant. It is essentially identical to this review.
Tests were added for chan_sip and updated for chan_pjsip - see https://reviewboard.asterisk.org/r/4420 . This includes both nominal and off-nominal offers negotiating SDES-SRTP.
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (Feb. 25, 2015, 4:23 p.m.)
  • changed from pending to submitted
Committed in revision 432276

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.