Review Board 1.7.16


testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

Review Request #4420 - Created Feb. 13, 2015 and submitted

Matt Jordan
testsuite
ASTERISK-17721, ASTERISK-17899, ASTERISK-22748
Reviewers
asterisk-dev
oej
testsuite
This patch adds nominal and off-nominal tests for SDP negotiation of SDES-SRTP crypto attributes, for both chan_sip and chan_pjsip.

Specifically:

* Moved the tests/channels/SIP/sip_srtp test to tests/channels/SIP/sip_srtp/srtp_call. This change was done merely to allow for additional SRTP tests for chan_sip, and is not part of this review. Note that due to a quirk of Review Board, the moved files don't show up in the review.

* Added tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer. This covers both nominal and off-nominal SDP offers with SDES-SRTP for chan_sip. Note that the scenarios use injection files to vary the crypto attributes.

* Updated tests/channels/PJSIP/srtp_negotiation.
  - All but two off-nominal scenarios were moved into a single off nominal scenario, decline.xml. This uses the same injection file for off nominal parameter testing as the chan_sip variant.
  - Updated accept_nominal.xml to use an injection file to test multiple nominal values.
  - Updated accept_multiple_attrib_first_bad.xml to not use a crypto attribute with lifetime as a 'bad' attribute.

 
Review request changed
Updated (Feb. 25, 2015, 4:28 p.m.)
  • changed from pending to submitted
Committed in revision 6466

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.