Review Board 1.7.16

res_pjsip_refer: Handle INVITE with Replaces failure after answer.

Review Request #4422 - Created Feb. 13, 2015 and submitted

* Fixed hangup handling of the session->channel after answer if the
ast_channel_move() or ast_bridge_impart() fails.  We are still the thread
controlling the session->channel so we need to call ast_hangup() to kill
the channel.

* Fixed debug messages in refer_incoming_invite_request() referencing
incorrect channnels on success.  Code comments now say why the
session->channel cannot be used.
Using testsuite test tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote
1) Ran with patch.  The debug log on ast2 was as expected.
2) Ran with patch and sabotaged code to "fail" ast_channel_move()/ast_bridge_impart().  The debug log on ast2 was as expected.
3) Ran with patch and sabotaged code to "fail" the initial test if the INVITE was a re-INVITE.  The debug log on ast2 was as expected.

Funny thing is the testsuite test passed for the three scenarios but a reactor timeout happened on 2 and 3.
Review request changed
Updated (Feb. 19, 2015, 12:25 p.m.)
  • changed from pending to submitted
Committed in revision 431973 runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to