Review Board 1.7.16


bridge_softmix: G.729 codec license held

Review Request #4429 - Created Feb. 16, 2015 and submitted

Kevin Harwell
11
ASTERISK-24797
Reviewers
asterisk-dev
Asterisk
When more than one call using the same codec type enters into a softmix bridge and no audio is present for a channel the bridge optimizes the out frame by using the same one for all channels with the same codec type. Unfortunately, when that number (channels with same codec type) dropped to <= 1 the codec was not dereferenced. At least not until all parties left the bridge. Thus in the case of G.729 the license was not released. This patch ensures that the codec is dereferenced immediately when the optimization no longer applies.


Created a 3 party confbridge. Two channels were using g.729 and the other using ulaw. Hung up both the channels using g.729 and noted that the confbridge was still holding a reference to a g.729 license. After applying the patch noted that it no longer held onto the license.
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (Feb. 24, 2015, 1:25 p.m.)
  • changed from pending to submitted
Committed in revision 432194

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.