Review Board 1.7.16

ISDN AOC: Fix crash from an AOC-E message that doesn't have a channel association.

Review Request #4430 - Created Feb. 17, 2015 and submitted

Processing an AOC-E event that does not or no longer has a channel
association causes a crash.

The problem with posting AOC events to the channel topic is that AOC-E
events don't always have a channel association and posting the event to
the all channels topic is just wrong.  AOC-E events do however have their
own charging association method to refer to the agreement with the
charging entity.

* Changed the AOC events to post to the AMI manager topic instead of the
channel topics.  If a channel is associated with the event then channel
snapshot information is supplied with the AMI event.

* Eliminated RAII_VAR() usage in aoc_to_ami() and ast_aoc_manager_event().

This patch supercedes the patch on Review:
Created a dummy AOC-E event with and without a channel association when an
ISDN call came in.  The AMI AOC-E events were generated as expected and
didn't crash.
Review request changed
Updated (Feb. 19, 2015, 1:23 p.m.)
  • changed from pending to submitted
Committed in revision 431991 runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to