Review Board 1.7.16


Update the kqueue timing module to conform to current timer API.

Review Request #4465 - Created March 9, 2015 and submitted

Justin T. Gibbs
ASTERISK-24857
Reviewers
asterisk-dev
Asterisk
Update the kqueue timing module to conform to current timer API.

This fixes issues with using the kqueue timing source on Asterisk 13
on FreeBSD 10.

res_timing_kqueue.c:
	Remove support for kevent64().  The values used to support Asterisk
	timers fit within 32bits and so can be handled on all platforms via
	kevent().

	Provide debug logging for, but do not track, unacked events.  This
	matches the behavior of all other timer implementations.

	Implement continuous mode by triggering and leaving active, a user
	event.  This ensures that the file descriptor for the timer returns
	immediately from poll(), without placing the load of a high speed
	timer on the kernel.

	In kqueue_timer_get_max_rate(), don't overstate the capability of
	the timer.  On some platforms, UINT_MAX is greater than INTPTR_MAX,
	the largest integer type kqueue supports for timers.

	In kqueue_timer_get_event(), assume the caller woke up from poll()
	and just return the mode the timer is currently in.  This matches
	all other timer implementations.

	Adjust the test code now that unacked events are not tracked.
Asterisk 13.2.0 on FreeBSD 10-stable: "timing test", pjsip incoming/outgoing calls, voicemail prompts and recordings.  All of the above failed without these changes.
Total:
9
Open:
0
Resolved:
9
Dropped:
0
Status:
From:
Review request changed
Updated (March 27, 2015, 10:24 a.m.)
  • changed from pending to submitted
Committed in revision 433594

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.