Review Board 1.7.16


res_pjsip: allow configuration of endpoint identifier query order

Review Request #4489 - Created March 13, 2015 and submitted

Kevin Harwell
13
ASTERISK-24840
Reviewers
asterisk-dev
Asterisk
Make sure that no matter what order the endpoint identifier modules were loaded, priority is given based on the ones specified in the new global 'endpoint_identifier_order' option.

The original patch for this issue had to be reverted due to some problems it created (original review: https://reviewboard.asterisk.org/r/4455/).

However, those problems have now been alleviated with the current patch on this review. Instead of having the associated endpoint identifier name directly contained on the identifier object (part of the externally exposed struct definition) the name is now passed in as part of the register function. The old register function has been left for backwards compatibility or for any modules that don't need to register with a name.
Ran the testsuite test and it still passed. Modified the test by changing the order of the identifiers and it failed (as it should have).
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (March 17, 2015, 2:24 p.m.)
  • changed from pending to submitted
Committed in revision 433052

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.