Review Board 1.7.16


ast_register_atexit should only be used when absolutely needed (13+ version)

Review Request #4501 - Created March 15, 2015 and submitted

Corey Farrell
11, 13, trunk
ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, ASTERISK-24881
Reviewers
asterisk-dev
Asterisk
We've had many issues related to "core stop now" or "core restart now" causing segmentation faults.  The solution to this is to change almost everything to use ast_register_cleanup.

Exceptions:
CDR: Flush records.
res_musiconhold: Kill external applications.
AstDB: Close the DB.
canary_exit: Kill canary process.

Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required.  For this reason the change is across the board.
Compiled, started and ran 'core stop now'.
Total:
3
Open:
0
Resolved:
2
Dropped:
1
Status:
From:
Description From Last Updated Status
Review request changed
Updated (March 26, 2015, 6:26 p.m.)
  • changed from pending to submitted
Committed in revision 433521

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.