Review Board 1.7.16


Audit ast_sockaddr_resolve() usage memory leaks.

Review Request #4509 - Created March 17, 2015 and submitted

rmudgett
13
Reviewers
asterisk-dev
Asterisk
Valgrind found some memory leaks associated with ast_sockaddr_resolve().
Most of the leaks had already been fixed by earlier memory leak hunt
patches.  This patch performs an audit of ast_sockaddr_resolve() and found
one more.

* Fix ast_sockaddr_resolve() memory leak in
apps/app_externalivr.c:app_exec().

* Made main/netsock2.c:ast_sockaddr_resolve() always set the addrs
parameter for safety so the pointer will never be uninitialized on return.
The same goes for res/res_pjsip_acl.c:extract_contact_addr().

* Made functions that call ast_sockaddr_resolve() with RAII_VAR()
controlling the addrs variable use ast_free instead of ast_free_ptr to
provide better MALLOC_DEBUG information.


This review is against v13 but a subset applies to v11.
Compiling and code inspection.
Review request changed
Updated (March 17, 2015, 5:25 p.m.)
  • changed from pending to submitted
Committed in revision 433084

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.