Review Board 1.7.16


app_confbridge (13): file playback blocks dtmf

Review Request #4510 - Created March 17, 2015 and submitted

Kevin Harwell
13
ASTERISK-24864
Reviewers
asterisk-dev
Asterisk
This is the Asterisk 13 version of the following: https://reviewboard.asterisk.org/r/4477/

Attempting to execute DTMF in a confbridge while file playback (prompt, announcement, etc) is occurring is not allowed. You have to wait until the sound file has completed before entering DTMF. This patch fixes it so that app_confbridge now monitors for dtmf key presses during file playback. If a key is pressed playback stops and it executes the matched menu option. Unlike the Asterisk 11 patch this version does not re-queue the dtmf frame, but instead uses an already available function that monitors for dtmf presses during playback.
Manual testing done. Setup a basic conference bridge that allowed both regular and admin users to enter. Ran through various menu options to make sure the sound file playback would stop (no longer have to wait) and a new option was executed when appropriate. Also ran the app_confbridge testsuite tests to make sure they still passed.
Total:
15
Open:
0
Resolved:
13
Dropped:
2
Status:
From:
Description From Last Updated Status
Review request changed
Updated (March 26, 2015, 12:26 p.m.)
  • changed from pending to submitted
Committed in revision 433468

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.