Review Board 1.7.16


res_pjsip_sdp_rtp,sorcery: Fix invalid access and memory leak respectively.

Review Request #4513 - Created March 18, 2015 and submitted

rmudgett
13
Reviewers
asterisk-dev
Asterisk
Valgrind found a memory leak and invalid access.

* Fix invalid access by sscanf() being fed a non-nul terminated string of
digits in res/res_pjsip_sdp_rtp.c:get_codecs().

* Fix memory leak in main/sorcery.c:sorcery_object_field_destructor().

* Fix potential NULL pointer dereference in
main/xmldoc.c:xmldoc_get_syntax_config_option().
* Placed a PJSIP call and observed that valgrind no longer complains of sscanf() performing an invalid read in get_codecs().

* Valgrind no longer complains of definitely leaked memory resulting from the sorcery_object_field_destructor().
Review request changed
Updated (March 20, 2015, 2:26 p.m.)
  • changed from pending to submitted
Committed in revision 433220

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.