Review Board 1.7.16


[15609] Prevent a stream of warnings about the voice frame queue too long

Review Request #452 - Created Dec. 30, 2009 and submitted

Tilghman Lesher
/branches/1.4
15609
Reviewers
asterisk-dev
Asterisk
A long running issue is that in certain circumstances, a Local channel will start spewing "WARNING[23025]: channel.c:952 __ast_queue_frame: Exceptionally long voice queue length queuing to Local" messages, at the end of a call.

Basically, this patch realizes that if a channel does not have a thread running (i.e. a slave channel) and there is no bridge (no thread to copy frames from the slave channel), then queuing frames to that channel is completely useless and only causes messages to be spewed.

However, given the simplicity of the patch for a problem which has consumed a great many developer hours, I would like verification that this is the correct approach.
Verified that the patch fixes the problem for the reporter.
Ship it!
Posted (Dec. 30, 2009, 9:29 a.m.)
This looks good to me.  I'm still curious why in older versions, this warning never occurred.  Something changed ... but in any case, like I said, I think this is a good change to make.  Good riddance to this issue.

Nice work, Tilghman.
Posted (Jan. 4, 2010, 4:07 a.m.)

   

  
/branches/1.4/channels/chan_local.c (Diff revision 1)
 
 
 
 
 
 
 
Unfortunately, I thought of some situations where this change will cause a problem.  Take the following originate for example:

*CLI> originate Local/1234@default/n application MeetMe 1234

In this case, there is no bridge, and there is no PBX on the channel.  However, this is still a valid scenario.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.