Review Board 1.7.16


clang compiler warning: -Wabsolute-value

Review Request #4525 - Created March 26, 2015 and submitted

Diederik de Groot
13
ASTERISK-24917
Reviewers
asterisk-dev
Asterisk
clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs

clang compiler warning:-Wabsolute-value

Changes:
/branches/13/apps/app_queue.c:3687 int -> long for avgholdmins, avgholdsecs;
/branches/13/apps/app_queue.c:6581 int -> long for holdtime, holdtimesecs;
/branches/13/channels/chan_iax2.c:6080 Moved "adjust" here, so it can help out in casting (ms - p->nextpred) to int
/branches/13/res/res_calendar.c:1109 Not sure if this is prefered over downcasting to int

 
Total:
4
Open:
0
Resolved:
0
Dropped:
4
Status:
From:
Review request changed
Updated (March 29, 2015, 10:26 p.m.)
  • changed from pending to submitted
Committed in revision 433771

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.