Review Board 1.7.16


clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

Review Request #4526 - Created March 26, 2015 and submitted

Diederik de Groot
13
ASTERISK-24917
Reviewers
asterisk-dev
Asterisk
clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs

clang compiler warning:-Wunused-value -Wunused-variable -Wunused-const-variable

Changes:
apps/app_queue.c: removed unused qpm_cmd_usage[], qum_cmd_usage[], qsmp_cmd_usage[]
cel/cel_sqlite3_custom.c: removed unused name[] = "cel_sqlite3_custom"
channels/chan_pjsip.c: removed unused desc[] = "PJSIP Channel"
codecs/gsm/src/gsm_create.c: removed unused ident[] = "$Header$"
funcs/func_env.c:729: Fixed ast_str_append_substr. Needs to be reviewed by code owner.
main/config.c: inline functions have to be static for clang to grok them
main/editline/np/strlcat.c: removed unused rcsid = "$OpenBSD: strlcat.c,v 1.2 1999/06/17 16:28:58 millert Exp $"
main/editline/np/strlcpy.c: removed unused rcsid = "$OpenBSD: strlcpy.c,v 1.4 1999/05/01 18:56:41 millert Exp $"
main/features.c: removed unused channel_app_data_datastore struct
main/security_events.c: removed unused TIMESTAMP_STR_LEN
utils/conf2ael.c: removed unused cfextension_states
utils/extconf.c: removed unused cfextension_states

 
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (March 28, 2015, 8:29 a.m.)
  • changed from pending to submitted
Committed in revision 433715

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.