Review Board 1.7.16


dns: Add SRV recording parsing, sorting/weighting, and unit tests

Review Request #4528 - Created March 26, 2015 and submitted

Joshua Colp
dns_srv
Reviewers
asterisk-dev
Asterisk
This change adds the following:

1. As SRV records are added to a result the information is parsed and stored away in additional storage in the record. The SRV API can then be used to return this information.
2. Before invoking the DNS query callback the list of records on the result are sorted based on priority and weight.
3. Unit tests have been added which verify the record parsing, sorting, and weighting. There are also some off nominal which cover the cases when an invalid/corrupt record is received.
4. A unit test has also been added to res_resolver_unbound which adds an SRV record to a zone and confirms it is retrieved and parsed correctly.
Executed unit tests and confirmed they pass.
Total:
3
Open:
0
Resolved:
3
Dropped:
0
Status:
From:
Review request changed
Updated (April 1, 2015, 12:24 p.m.)
  • changed from pending to submitted
Committed in revision 433914

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.