Review Board 1.7.16


clang compiler warning: -Wparentheses-equality

Review Request #4531 - Created March 26, 2015 and submitted

Diederik de Groot
13
ASTERISK-24917
Reviewers
asterisk-dev
Asterisk
clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs

clang compiler warning:-Wparentheses-equality

Changes:
Needed to suppress this warning for the generated file 'ael.tab.c' over which we don't have control

 

Diff revision 2 (Latest)

1 2
1 2

  1. /branches/13/apps/app_dictate.c: Loading...
  2. /branches/13/apps/app_voicemail.c: Loading...
  3. /branches/13/main/channel.c: Loading...
  4. /branches/13/res/Makefile: Loading...
  5. /branches/13/utils/Makefile: Loading...
/branches/13/apps/app_dictate.c
Revision 433444 New Change
[20] 172 lines
[+20] [+] static int dictate_exec(struct ast_channel *chan, const char *data)
173
			if (digit) {
173
			if (digit) {
174
				struct ast_frame fr = {AST_FRAME_DTMF, { .integer = digit } };
174
				struct ast_frame fr = {AST_FRAME_DTMF, { .integer = digit } };
175
				ast_queue_frame(chan, &fr);
175
				ast_queue_frame(chan, &fr);
176
				digit = 0;
176
				digit = 0;
177
			}
177
			}
178
			if ((f->frametype == AST_FRAME_DTMF)) {
178
			if (f->frametype == AST_FRAME_DTMF) {
179
				int got = 1;
179
				int got = 1;
180
				switch(mode) {
180
				switch(mode) {
181
				case DMODE_PLAY:
181
				case DMODE_PLAY:
182
					switch (f->subclass.integer) {
182
					switch (f->subclass.integer) {
183
					case '1':
183
					case '1':
[+20] [20] 176 lines
/branches/13/apps/app_voicemail.c
Revision 433444 New Change
 
/branches/13/main/channel.c
Revision 433444 New Change
 
/branches/13/res/Makefile
Revision 433444 New Change
 
/branches/13/utils/Makefile
Revision 433444 New Change
 
  1. /branches/13/apps/app_dictate.c: Loading...
  2. /branches/13/apps/app_voicemail.c: Loading...
  3. /branches/13/main/channel.c: Loading...
  4. /branches/13/res/Makefile: Loading...
  5. /branches/13/utils/Makefile: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.