Review Board 1.7.16


Restrict ast_log_safe use from utils.h to the core only.

Review Request #4548 - Created March 27, 2015 and submitted

Corey Farrell
11, 13, trunk
Reviewers
asterisk-dev
rmudgett, sgriepentrog
Asterisk
When modules are distributed as binaries, they are sometimes built against the latest Asterisk in a branch, but need to be able to run against any version within that branch.  The recent addition of ast_log_safe can pose a problem in this situation.  The new function is used from utils.h, but the symbol is not available in older versions.  The solution to this is to have modules just use ast_log for OOM errors.  The core will still use ast_log_safe for OOM errors, so this will protect against infinite logger recursion.
make cdr main utils

Check object files with 'nm -g' to verify that main/*.o still used ast_log_safe.  Verified that cdr/*.o and utils/*.o did not use ast_log_safe.
Review request changed
Updated (March 30, 2015, 7:26 a.m.)
  • changed from pending to submitted
Committed in revision 433794

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.