Review Board 1.7.16


ARI: Add the ability to intercept hold and raise an event

Review Request #4549 - Created March 27, 2015 and submitted

Matt Jordan
13
ASTERISK-24922
Reviewers
asterisk-dev
file
Asterisk
For some applications - such as SLA - a phone pressing hold should not behave in the fashion that the Asterisk core would like it to. Instead, the hold action has some application specific behaviour associated with it - such as disconnecting the channel that initiated the hold; only playing MoH to channels in the bridge if the channels are of a particular type, etc.

One way of accomplishing this is to use a framehook to intercept the hold/unhold frames, raise an event, and eat the frame. Tasty. The patch attached to this issue accomplished that as a new dialplan function, HOLD_INTERCEPT.

In addition:
* ARI now queues hold/unhold frames instead of indicating frames directly. This allows for the Stasis hold/unhold messages to be raised.
* Some general cleanup of raising hold/unhold Stasis messages was done, including removing some RAII_VAR usage.
See Gerrit reviews:

https://gerrit.asterisk.org/#/c/16
https://gerrit.asterisk.org/#/c/17
Total:
3
Open:
0
Resolved:
3
Dropped:
0
Status:
From:
Review request changed
Updated (April 7, 2015, 11:26 a.m.)
  • changed from pending to submitted
Committed in revision 434238

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.