Review Board 1.7.16


testsuite: Add PJSIP test for new auto_dtmf option.

Review Request #4576 - Created April 2, 2015 and updated

yaron nahum
ASTERISK-24706
Reviewers
asterisk-dev
testsuite
This is the testsuite test to test the auto_dtmf option added by review:
https://reviewboard.asterisk.org/r/4438/

The test passes.

 
Total:
3
Open:
3
Resolved:
0
Dropped:
0
Status:
From:
Posted (April 6, 2015, 12:56 p.m.)
Nice job on the test! Just a few minor documentation findings.

For future reference, the Asterisk Test Suite has been migrated over to Git. You can get the latest and greatest from gerrit.asterisk.org - and also post any new patches there as well. Instructions on using Gerrit are up on the Asterisk wiki:

https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

I'll be happy to move the patch over for you if you don't want to go through the hassle.

I think you might have a copy/paste issue here on the summary and description :-)

The minversion should be 13.4.0, as that is when the 'auto' support mode will be added.
You don't need to specify that the test depends on those modules.
Posted (April 10, 2015, 9:50 a.m.)
I'm going to go ahead and post this for review on Gerrit (gerrit.asterisk.org) - particularly since the 'findings' were very minor.

That will allow us to go ahead and commit the patch for the auto-dtmf mode ahead of the move to Git next week.
  1. Actually, I just noticed that the pcap files containing the RFC 4733 DTMF and the Inband DTMF were never attached to the review. Can you svn add them and post them up here? Barring that, attaching them to the Asterisk issue would suffice.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.