Review Board 1.7.16

res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

Review Request #4589 - Created April 3, 2015 and submitted

Juergen Spies
Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default value or a value provided
in pjsip.conf (t38_udptl_maxdatagram).
Without this far_max_datagram remains -1 if the remote endpoint does not provide the MediaAttribute T38FaxMaxDatagram
in it's SIP INVITE SDP. This will result in the INVITE being rejected.
I have tested the patch with the following setup. The Asterisk is acting as relay.
The external T.38 gateway is at our ISP. The internal gateway is a Cisco SPA112.
The ISP’s gateway does not include T38FaxMaxDatagram in SDPs.

The test cases included:
- No t38_udptl_maxdatagram in pjsip.conf
  o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco),
  o Outbound fax w/o T38FaxMaxDatagram in SDP,
- t38_udptl_maxdatagram defined in pjsip.conf for both endpoints
  o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco).

All tests were completed successfully.
Review request changed
Updated (April 11, 2015, 10:25 a.m.)
  • changed from pending to submitted
Committed in revision 434704 runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to