res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()
Review Request #4589 - Created April 3, 2015 and submitted
Juergen Spies | |
ASTERISK-24928 | |
Reviewers | |
---|---|
asterisk-dev | |
Asterisk |
Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default value or a value provided in pjsip.conf (t38_udptl_maxdatagram). Without this far_max_datagram remains -1 if the remote endpoint does not provide the MediaAttribute T38FaxMaxDatagram in it's SIP INVITE SDP. This will result in the INVITE being rejected.
I have tested the patch with the following setup. The Asterisk is acting as relay. The external T.38 gateway is at our ISP. The internal gateway is a Cisco SPA112. The ISP’s gateway does not include T38FaxMaxDatagram in SDPs. The test cases included: - No t38_udptl_maxdatagram in pjsip.conf o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco), o Outbound fax w/o T38FaxMaxDatagram in SDP, - t38_udptl_maxdatagram defined in pjsip.conf for both endpoints o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco). All tests were completed successfully.
Posted (April 6, 2015, 8:24 a.m.)
I think the t38_interpret_sdp function should be updated to only set the far max datagram if not explicitly configured. Right now it will set it again needlessly.
Review request changed
Updated (April 6, 2015, 10:53 a.m.)
-
- added Diff r2 - Show changes
Posted (April 7, 2015, 2:06 p.m.)
I want to give this a "Ship It!" but the "Testing Done" section is not filled in at all. What has been done to test this change?
Review request changed
Updated (April 10, 2015, 3:49 a.m.)
-
I have tested the patch with the following setup. The Asterisk is acting as relay. The external T.38 gateway is at our ISP. The internal gateway is a Cisco SPA112. The ISP’s gateway does not include T38FaxMaxDatagram in SDPs. The test cases included: - No t38_udptl_maxdatagram in pjsip.conf o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco), o Outbound fax w/o T38FaxMaxDatagram in SDP, - t38_udptl_maxdatagram defined in pjsip.conf for both endpoints o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco). All tests were completed successfully.
Ship It!
Ship It!
Ship It!
Review request changed
Updated (April 11, 2015, 10:25 a.m.)
- changed from pending to submitted
Committed in revision 434704
Other reviews