Review Board 1.7.16


When setting a soundfile for announce with a length longer then 80 chars a storage overlay happens

Review Request #475 - Created Jan. 26, 2010 and submitted

syspert
trunk
Reviewers
asterisk-dev
Asterisk
Crash in app_queue.
Changed the length of the announce field from 80 to PATH_MAX

ref = https://issues.asterisk.org/view.php?id=16488
Tested with long soundfile names.

Diff revision 1 (Latest)

  1. /trunk/apps/app_queue.c: Loading...
/trunk/apps/app_queue.c
Revision 235811 New Change
[20] 797 lines
[+20] [+] struct callattempt {
798

    
   
798

   
799

    
   
799

   
800
struct queue_ent {
800
struct queue_ent {
801
	struct call_queue *parent;             /*!< What queue is our parent */
801
	struct call_queue *parent;             /*!< What queue is our parent */
802
	char moh[80];                          /*!< Name of musiconhold to be used */
802
	char moh[80];                          /*!< Name of musiconhold to be used */
803
	char announce[80];                     /*!< Announcement to play for member when call is answered */
803
	char announce[PATH_MAX];               /*!< Announcement to play for member when call is answered */
804
	char context[AST_MAX_CONTEXT];         /*!< Context when user exits queue */
804
	char context[AST_MAX_CONTEXT];         /*!< Context when user exits queue */
805
	char digits[AST_MAX_EXTENSION];        /*!< Digits entered while in queue */
805
	char digits[AST_MAX_EXTENSION];        /*!< Digits entered while in queue */
806
	int valid_digits;                      /*!< Digits entered correspond to valid extension. Exited */
806
	int valid_digits;                      /*!< Digits entered correspond to valid extension. Exited */
807
	int pos;                               /*!< Where we are in the queue */
807
	int pos;                               /*!< Where we are in the queue */
808
	int prio;                              /*!< Our priority */
808
	int prio;                              /*!< Our priority */
[+20] [20] 6904 lines
  1. /trunk/apps/app_queue.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.