Review Board 1.7.16


Add abliity for logger channels to include *all* levels

Review Request #663 - Created May 18, 2010 and submitted

Kevin Fleming
trunk
Reviewers
asterisk-dev
Asterisk
Now that Asterisk modules can dynamically create and destroy logger levels on demand, it's useful to be able to configure a logger channel (console, file, whatever) to be able to accept log messages from *all* levels, even levels created dynamically. This patch adds support for this, by allowing the '*' level name to be used in logger.conf.
Compile testing only.
Ship it!
Posted (May 18, 2010, 8:10 a.m.)
One thing I noticed while looking at your review is that the "found" variable in make_components() is not actually used for anything useful and can be removed.

Good work!
/trunk/configs/logger.conf.sample (Diff revision 1)
 
 
 
 
Maybe I'm being a bit paranoid, but the parenthetical comment stating that no reload is required may be misconstrued. For instance, it seems reasonable for someone reading this to think that they can add the '*' level to a log channel in logger.conf and not need to reload after making the change.
Posted (May 20, 2010, 12:56 a.m.)

   

  
/trunk/main/logger.c (Diff revision 1)
 
 
Why is this 0xFFFF rather than 0XFFFFFFFF
I may have misunderstood but are not the dynamic levels that you wish to allow the ones between 16-31. If so it would appear that 0xFFFF would only allow the static levels 

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.