Review Board 1.7.16


If 'faxdetect=yes' in sip.conf, switch to a 'fax' extension after T38 is negotiated

Review Request #69 - Created Dec. 2, 2008 and submitted

Dwayne Hubbard
Reviewers
asterisk-dev
bmd, file, kpfleming, mmichelson, russell, twilson
Asterisk
If 'faxdetect=yes' in sip.conf, switch to a 'fax' extension after T38 is negotiated.  Terry Wilson created the original patch for this functionality, which I slightly modified and added the faxdetect=yes|no configuration option.  This patch is only for T38 fax detection and does not do anything for G711 over SIP fax detection.  This is for issue AST-140.
1.  Applied patch to asterisk/trunk revision 160384 and built Asterisk.
2.  Set faxdetect=no in /etc/asterisk/sip.conf and make a T38 fax call into Asterisk.  Verified the channel did not switch to the 'fax' extension after T38 was negotiated.
3.  Set faxdetect=yes in /etc/asterisk/sip.conf and make a T38 fax call into Asterisk.  Verified the channel switched to the fax extension after T38 was negotiated.
4.  Set faxdetect=no in /etc/asterisk/sip.conf and make a T38 fax call into Asterisk.  Verified the channel did not switch to the 'fax' extension after T38 was negotiated.
Review request changed
Updated (Dec. 4, 2008, 10:10 a.m.)
Addressed all of Russell's comments, then retested using the same steps described in the Testing Done section.
Ship it!
Posted (Dec. 4, 2008, 10:12 a.m.)

   

  

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.