Review Board 1.7.16


Make the parameter separator backward compatible, and error messages more consistent.

Review Request #79 - Created Dec. 4, 2008 and updated

Eliel SardaƱons
Reviewers
asterisk-dev
Asterisk
This patch implements an asterisk.conf [compat] option called app_delim, to make applications and functions parameter delimiter backward compatible. if app_delim < 1.5 then, then app/fun delimited should be | (pipe), otherwise it should be "," comma.
Also there are a number of functions that where not using STANDARD_APP_ARG to parse the app/fun parameters, so, that was changed to use AST_STANDARD_APP_DELIM.
When printing error messages, we where printing the "syntax" with a hardcoded parameter separator, now the syntax being printed is the one generated with the xml documentation, so the error messages will be consistent with the actual parameter separator, and also with the actual app/fun syntax.
Developer testing.
Review request changed
Updated (April 23, 2009, 6:27 a.m.)
Address Mark's comments searching for pbx_findapp, pbx_exec, etc to replace other places where a ',' was used instead of AST_STANDARD_APP_DELIM.

There is a place in app_mixmonitor that couldn't figure out what was trying to replace (also the code was duplicated), maybe that is another place to use ast_standard_app_delim.
Ship it!
Posted (Feb. 23, 2010, 9:16 a.m.)
This may not exactly touch every single case where a hardcoded ',' is used in the code, but committing this as-is is an excellent start and at least will give a suitable template for how future coding should be done. Great job, Eliel, and sorry no one looked at this sooner.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.