Review Board 1.7.16


Expand MEETME_INFO() with new options

Review Request #812 - Created July 28, 2010 and updated

Olle E Johansson
trunk
Reviewers
asterisk-dev
Asterisk
Simple patch that expands MEETME_INFO() with a few new options. 

 
Review request changed
Updated (Dec. 14, 2012, 12:56 a.m.)
Updates according to very old review.
Posted (Dec. 31, 2012, 4:02 a.m.)

   

  
/trunk/apps/app_meetme.c (Diff revision 2)
 
 
I dislike the way this has gotten structured - we now have:

-1: invalid keyword, returned from acf_meetme_info_eval
-2: conference not found, not returned from acf_meetme_info_eval
-3: not an error but rather a signal to not copy the result into the buffer, returned from acf_meetme_info_eval.

Yikes.

Instead of that, why not have acf_meetme_info_eval *always* copy the result into buf, and return success or error?  That eliminates needing to return -3, and simplifies the code here.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.