Review Board 1.7.16


Add 'ignoresdpversion' option to chan_sip to support non-standard SDP behavior

Review Request #94 - Created Dec. 17, 2008 and submitted

Matthew Nicholson
trunk
13958
Reviewers
asterisk-dev
Asterisk
This patch adds a new 'ignoresdpversion' option to sip.conf.  When this is enabled (either globally or for a specific peer), chan_sip will treat any SDP data it receives as new data and update the media stream accordingly.  By default, Asterisk will only modify the media stream if the SDP session version received is different from the current SDP session version.  This option is required to interoperate with devices that have non-standard SDP session version implementations (observed by toc on the bug tracker with Microsoft OCS which always uses 0 as the session version).
Toc on the bug tracker tested this patch and I made sure it compiled with --enable-dev-mode.
Posted (Dec. 17, 2008, 4:58 a.m.)

   

  
trunk/channels/chan_sip.c (Diff revision 1)
 
 
The output from this line is longer then the rest.  I suppose this could be abrivated to something like 'Ign SDP ver:'.
Posted (Dec. 17, 2008, 4:58 a.m.)

   

  
trunk/channels/chan_sip.c (Diff revision 1)
 
 
Same as above.
Ship it!
Posted (Dec. 17, 2008, 6:12 a.m.)
It looks correct to me! Good job updating the sample configs and CHANGES files too.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.