Review Board 1.7.16


Terry Wilson
Last logged in September 11th, 2013
Joined October 20th, 2008


twilson's review requests

Starred Summary Submitter Posted Last Updated Edit columns
Make callbackextension work for realtime and also match on callbackextension when multiple peers with the same host have differing callbackextensions twilson February 7th, 2012, 1:45 p.m.
Add xmldoc for config options, along with some CLI commands for viewing config option-related stuff twilson July 18th, 2012, 7:15 p.m.
SIP Session Timer: Call drops because misunderstanding of uac and uas refresher role twilson September 18th, 2012, 5:59 p.m.
Better handling of reinvite timeouts twilson July 2nd, 2012, 12:49 p.m.
Revamp app_confbridge into something resembling a state machine twilson August 15th, 2012, 5 p.m.
Properly detect overflow on int32 and uint32 types in ast_parse_arg twilson August 16th, 2012, 4:58 p.m.
Convert app_confbridge to use the new config options API twilson July 9th, 2012, 12:17 p.m.
Handle deprecated (aliased) option names with the config options api twilson July 9th, 2012, 6:14 p.m.
Add the ability to set flags via the config options api twilson June 26th, 2012, 7:13 p.m.
A new higher-level API for working with Asterisk configs, with example code in app_skel.c and udptl.c twilson April 16th, 2012, 12:22 p.m.
Add post_apply callback for config options api twilson June 7th, 2012, 4:39 p.m.
Add the ability to support filename aliases for the Config Options API twilson June 7th, 2012, 6:35 p.m.
Fix reloading an unchanged file with the Config Options API twilson June 7th, 2012, 10:46 a.m.
Make the ACL default handler more consistent with other default handlers and document how each handler works twilson June 5th, 2012, 10:56 p.m.
Two new CEL-related fixes twilson May 4th, 2012, 5:45 p.m.
Don't use a variable after calling ASTOBJ_UNREF on it. twilson May 21st, 2012, 3:45 p.m.
Add CEL testing to the testsuite twilson May 4th, 2012, 6:31 p.m.
Properly handle the linkedid for local channels and fix race condition for LINKEDID_END CEL event. twilson May 2nd, 2012, 8:23 a.m.
Fix range checking with ast_parse_arg numeric types and add tests twilson April 23rd, 2012, 6:18 p.m.
Fix the handling of multiple CLI commands via socket twilson April 18th, 2012, 9:50 p.m.
Convert two classes of strncpy usage to ast_copy_string twilson February 10th, 2012, 8:02 p.m.
Fix setting CDR accountcode/userfield in hangup exten twilson March 6th, 2012, 10:02 a.m.
Make sure ast_config_destroy is called when configs aren't supposed to stick around twilson March 27th, 2012, 4:04 p.m.
Make hints for non-existant SIP devices show up as Unavailable instead of Idle twilson March 7th, 2012, 6:44 p.m.
Opaquify remaining fields and move struct ast_channel into main/channel_internal_api.c twilson March 1st, 2012, 4:36 p.m.
Update to review 1160 twilson March 7th, 2012, 7:17 a.m.
Opaquify some ast_channel typedefs, file descriptor arrays, and the _softhangup flag twilson February 29th, 2012, 12:20 p.m.
Opaquify ast_channel lists and structs twilson February 24th, 2012, 3:44 p.m.
If a CDR variable is set during a bridged call, make sure the values get copied over to the bridge CDR twilson February 7th, 2012, 6:15 p.m.
Opaquify ast_format structs in the ast_channel twilson February 23rd, 2012, 4:22 p.m.
Make ast_unload_resource actually remove the module from the module list when it is unloaded twilson February 17th, 2012, 9:43 p.m.
Fix test_utils.c and test_substitution.c for latest opaquification commit twilson February 22nd, 2012, 6:24 p.m.
ast_channel opaquification: most pointers, integer types twilson February 18th, 2012, 1:35 p.m.
Opaquify const char * and char[] in the ast_channel twilson February 11th, 2012, 2:19 p.m.
Document that CDRs cannot be modified after the bridge between two channels is broken twilson February 7th, 2012, 4:29 p.m.
Add a SIP nat=auto setting twilson January 26th, 2012, 7:58 p.m.
Fix broken SIP realtime update of lastms (and a couple other SIP realtime issues) twilson January 31st, 2012, 9:53 p.m.
Allow res_calendar to be unloaded twilson January 7th, 2012, 1:03 p.m.
Add update callback to dnsmgr since chan_sip peers need to be re-linked in peers_by_ip when the IP changes twilson January 25th, 2012, 11:43 a.m.
Add result variable to make it possible to know that a CALENDAR_WRITE has failed. twilson January 25th, 2012, 2:01 p.m.
Continue ast_channel opaque-ification with accessor functions for the rest of the stringfields twilson January 9th, 2012, 4:52 p.m.
Cleanup some SIP registry-related memory leaks twilson January 24th, 2012, 6:10 p.m.
Don't leak caller-id info in the From header when sending rpid header if caller presentation is set to unavailable. twilson January 4th, 2012, 3:13 p.m.
Don't keep channel up while we are waiting for possible retransmissions of non-200 responses on an INVITE twilson January 16th, 2012, 1:02 p.m.
Don't run the atexit functions more than once twilson January 7th, 2012, 3:29 p.m.
Start the process of opaque-ifying the ast_channel by replacing direct access to the 'name' field with accessor functions. twilson January 6th, 2012, 2:42 p.m.
Use the proper type for ast_codec_pref's framing field so that packetization values > 127 can be used twilson December 21st, 2011, 11:29 p.m.
Add the ability to capture and analyze packets twilson December 14th, 2011, 10:10 p.m.
Don't sleep waiting for fullybooted twilson December 9th, 2011, 10:51 a.m.
Add the install path of astdb2sqlite3 to paths.h to avoid relying on $PATH when doing automatic astdb conversion twilson December 6th, 2011, 4:50 p.m.
1 2 3 > 3 pages runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to